moved internal clients into internal/client package #896
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
- Coverage 66.85% 66.69% -0.17%
==========================================
Files 258 258
Lines 24527 24529 +2
==========================================
- Hits 16397 16359 -38
- Misses 7288 7320 +32
- Partials 842 850 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github.com/ydb-platform/ydb-go-sdk/v3incompatible changesWithRatelimiterOptions: changed from func(...github.com/ydb-platform/ydb-go-sdk/v3/internal/ratelimiter/config.Option) Option to func(...github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/ratelimiterImpl/config.Option) Option github.com/ydb-platform/ydb-go-sdk/v3/ratelimiterincompatible changesClient.AcquireResource: changed from func(context.Context, string, string, uint64, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/ratelimiter/options.AcquireOption) error to func(context.Context, string, string, uint64, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/ratelimiterImpl/options.AcquireOption) error github.com/ydb-platform/ydb-go-sdk/v3/testutilincompatible changesNewTopicReaderMessageBuilder: changed from func() *github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicreaderinternal.PublicMessageBuilder to func() *github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/topicImpl/topicreaderinternal.PublicMessageBuilder github.com/ydb-platform/ydb-go-sdk/v3/topicincompatible changesClient.StartReader: changed from func(string, github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions.ReadSelectors, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicreaderinternal.PublicReaderOption) (*github.com/ydb-platform/ydb-go-sdk/v3/topic/topicreader.Reader, error) to func(string, github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions.ReadSelectors, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/topicImpl/topicreaderinternal.PublicReaderOption) (*github.com/ydb-platform/ydb-go-sdk/v3/topic/topicreader.Reader, error) github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptionsincompatible changesCheckErrorRetryArgs: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/topic.PublicCheckErrorRetryArgs to github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/topicImpl.PublicCheckErrorRetryArgs github.com/ydb-platform/ydb-go-sdk/v3/topic/topicreaderincompatible changes(*Reader).Commit: changed from func(context.Context, github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicreaderinternal.PublicCommitRangeGetter) error to func(context.Context, github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/topicImpl/topicreaderinternal.PublicCommitRangeGetter) error github.com/ydb-platform/ydb-go-sdk/v3/topic/topicsugarincompatible changesJSONUnmarshal: changed from func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicreaderinternal.PublicMessage, interface{}) error to func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/topicImpl/topicreaderinternal.PublicMessage, interface{}) error github.com/ydb-platform/ydb-go-sdk/v3/topic/topicwriterincompatible changes(*Writer).Write: changed from func(context.Context, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.Message) error to func(context.Context, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/clients/topicImpl/topicwriterinternal.Message) error summaryBase version: v3.54.3-0.20231115182119-3c08fa394e44 (master) |
|
🌋 Here are results of SLO test for Go SDK native: |
|
🌋 Here are results of SLO test for Go SDK database/sql: |
|
🌋 Here are results of SLO test for Go SDK gorm: |
|
🌋 Here are results of SLO test for Go SDK xorm: |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information