Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change golangci to enable all #903

Conversation

Mixalight
Copy link
Contributor

@Mixalight Mixalight commented Dec 5, 2023

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #738

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (863b2aa) 66.85% compared to head (cdad252) 38.89%.

Files Patch % Lines
options.go 10.25% 35 Missing ⚠️
driver.go 10.00% 9 Missing ⚠️
sql.go 50.00% 1 Missing ⚠️
sql_unwrap.go 0.00% 1 Missing ⚠️
sql_unwrap_go1.18.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #903       +/-   ##
===========================================
- Coverage   66.85%   38.89%   -27.96%     
===========================================
  Files         258      212       -46     
  Lines       24527    21408     -3119     
===========================================
- Hits        16397     8327     -8070     
- Misses       7288    12734     +5446     
+ Partials      842      347      -495     
Flag Coverage Δ
?
go-1.17.x 38.61% <11.53%> (-26.62%) ⬇️
go-1.20.x 38.80% <11.53%> (-27.87%) ⬇️
go-1.21.x 38.80% <11.53%> (-28.05%) ⬇️
integration ?
macOS 38.80% <11.32%> (-0.02%) ⬇️
ubuntu 38.80% <11.32%> (-0.07%) ⬇️
unit 38.89% <11.32%> (-0.07%) ⬇️
windows 38.57% <11.53%> (-0.34%) ⬇️
ydb-22.5 ?
ydb-23.1 ?
ydb-23.2 ?
ydb-23.3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit aec710b into ydb-platform:master Dec 10, 2023
41 of 49 checks passed
rekby added a commit that referenced this pull request Dec 12, 2023
because linters are broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants