internal message to public message - because the message is part of p… #910

rekby · 2023-12-14T14:25:10Z

…ublic interface

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

github-actions · 2023-12-14T14:25:58Z

github.com/ydb-platform/ydb-go-sdk/v3/topic/topicwriter

incompatible changes

(*Writer).Write: changed from func(context.Context, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.Message) error to func(context.Context, ...github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.PublicMessage) error
Message: changed from github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.Message to github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal.PublicMessage

summary

Base version: v3.54.3-rc0 (master)
Suggested version: v3.54.3

codecov-commenter · 2023-12-14T14:32:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1d4f44) 66.50% compared to head (bee38c7) 66.58%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   66.50%   66.58%   +0.08%     
==========================================
  Files         258      258              
  Lines       24618    24618              
==========================================
+ Hits        16371    16393      +22     
+ Misses       7395     7379      -16     
+ Partials      852      846       -6

Flag	Coverage Δ
	`53.24% <100.00%> (+0.17%)`	⬆️
go-1.17.x	`65.09% <100.00%> (+0.16%)`	⬆️
go-1.20.x	`66.56% <100.00%> (+0.23%)`	⬆️
go-1.21.x	`66.26% <100.00%> (+0.03%)`	⬆️
integration	`53.24% <100.00%> (+0.17%)`	⬆️
macOS	`38.72% <100.00%> (+<0.01%)`	⬆️
ubuntu	`38.74% <100.00%> (-0.03%)`	⬇️
unit	`38.81% <100.00%> (-0.03%)`	⬇️
windows	`38.81% <100.00%> (+0.01%)`	⬆️
ydb-22.5	`52.95% <100.00%> (+0.10%)`	⬆️
ydb-23.1	`52.83% <100.00%> (+0.24%)`	⬆️
ydb-23.2	`53.09% <100.00%> (+0.43%)`	⬆️
ydb-23.3	`53.06% <100.00%> (+0.13%)`	⬆️