Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver string #914

Merged
merged 5 commits into from
Dec 25, 2023
Merged

Driver string #914

merged 5 commits into from
Dec 25, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Alex Bitkov and others added 4 commits December 10, 2023 23:02
@asmyasnikov asmyasnikov added the enhancement New feature or request label Dec 25, 2023
@asmyasnikov asmyasnikov self-assigned this Dec 25, 2023
Copy link

github.com/ydb-platform/ydb-go-sdk/v3

compatible changes

(*Driver).String: added

summary

Base version: v3.54.3-rc0.0.20231225074356-10479c6fb2ea (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.3-rc0.

@asmyasnikov asmyasnikov force-pushed the driver-string branch 2 times, most recently from 10ae9e4 to 2882334 Compare December 25, 2023 08:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10479c6) 67.55% compared to head (33798c9) 67.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   67.55%   67.48%   -0.07%     
==========================================
  Files         260      261       +1     
  Lines       24675    24687      +12     
==========================================
- Hits        16670    16661       -9     
- Misses       7145     7164      +19     
- Partials      860      862       +2     
Flag Coverage Δ
54.08% <4.16%> (-0.12%) ⬇️
go-1.17.x 65.84% <100.00%> (+0.06%) ⬆️
go-1.20.x 67.42% <100.00%> (+<0.01%) ⬆️
go-1.21.x 67.38% <100.00%> (-0.02%) ⬇️
integration 54.08% <4.16%> (-0.12%) ⬇️
macOS 38.81% <100.00%> (+0.06%) ⬆️
ubuntu 38.80% <100.00%> (+<0.01%) ⬆️
unit 38.89% <100.00%> (+0.02%) ⬆️
windows 38.87% <100.00%> (+0.03%) ⬆️
ydb-22.5 53.47% <4.16%> (-0.33%) ⬇️
ydb-23.1 53.76% <4.16%> (-0.12%) ⬇️
ydb-23.2 53.82% <4.16%> (+0.09%) ⬆️
ydb-23.3 53.95% <4.16%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 25, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

Copy link

github-actions bot commented Dec 25, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

Copy link

github-actions bot commented Dec 25, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

Copy link

github-actions bot commented Dec 25, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@asmyasnikov asmyasnikov force-pushed the driver-string branch 2 times, most recently from 8249d89 to a8f6159 Compare December 25, 2023 08:40
@asmyasnikov asmyasnikov merged commit b493e0b into master Dec 25, 2023
49 checks passed
@asmyasnikov asmyasnikov deleted the driver-string branch December 25, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants