Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadcode enabled #987

Merged
merged 1 commit into from
Dec 30, 2023
Merged

deadcode enabled #987

merged 1 commit into from
Dec 30, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #923

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Dec 30, 2023
Copy link

summary

Base version: v3.54.4-0.20231230175649-59e5a9563eb2 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.54.3.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59e5a95) 67.45% compared to head (f1fa11c) 38.84%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #987       +/-   ##
===========================================
- Coverage   67.45%   38.84%   -28.61%     
===========================================
  Files         261      213       -48     
  Lines       24686    21509     -3177     
===========================================
- Hits        16652     8356     -8296     
- Misses       7165    12799     +5634     
+ Partials      869      354      -515     
Flag Coverage Δ
?
go-1.17.x 38.52% <ø> (-27.46%) ⬇️
go-1.20.x 38.83% <ø> (-28.47%) ⬇️
go-1.21.x ?
integration ?
macOS ?
ubuntu 38.84% <ø> (+<0.01%) ⬆️
unit 38.84% <ø> (-0.08%) ⬇️
windows ?
ydb-22.5 ?
ydb-23.1 ?
ydb-23.2 ?
ydb-23.3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov merged commit e785ae2 into master Dec 30, 2023
47 of 49 checks passed
@asmyasnikov asmyasnikov deleted the deadcode branch December 30, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants