Add query statistics support #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
reviewed
Dec 6, 2024
|
|
||
|
|
||
| let mut tx = client.table_client().create_interactive_transaction(); | ||
| let res = tx.query(Query::new( |
There was a problem hiding this comment.
YDB may delay some operations, for example all changes delay up to end of transation if no need result of the update (for example read the table). Try check statistic on commit or try read same table - for force apply upsert
|
|
||
| println!("{:?}", res.stats); | ||
|
|
||
| assert_eq!(2, res.stats.map(|x|x.rows_affected()).unwrap_or(0)); |
There was a problem hiding this comment.
The reason same as above: upsert delay apply until ydb need it. In the case - up to the select. And upsert really apply only on when you send select.
You can select twice: upsert will be applied for first select and you will see only reads for second select.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Other information
there are two tests:
first failed because no table access stats, second failed because it show two phases: update and read (?) when i send only second query with stats collection