Skip to content

Commit

Permalink
Enable discovery flag
Browse files Browse the repository at this point in the history
  • Loading branch information
FloatingCrowbar committed Jan 9, 2025
1 parent beff14d commit 8edbfd6
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ydb/core/kafka_proxy/actors/kafka_metadata_actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ void TKafkaMetadataActor::AddCurrentNodeToBrokers() {
}

void TKafkaMetadataActor::SendDiscoveryRequest() {
if (!Context->Config.GetEnableEndpointDiscovery())
return;
DiscoveryRequested = true;
if (!DiscoveryCacheActor) {
OwnDiscoveryCache = true;
Expand Down
3 changes: 3 additions & 0 deletions ydb/core/kafka_proxy/ut/port_discovery_ut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ namespace NKafka::NTests {
ui16 kafkaPort = pm->GetPort();
auto serverSettings = NPersQueueTests::PQSettings(0).SetDomainName("Root").SetNodeCount(1);
serverSettings.AppConfig->MutableKafkaProxyConfig()->SetEnableKafkaProxy(true);
serverSettings.AppConfig->MutableKafkaProxyConfig()->SetEnableEndpointDiscovery(true);
serverSettings.AppConfig->MutableKafkaProxyConfig()->SetListeningPort(kafkaPort);
NPersQueue::TTestServer server(serverSettings, true, {}, NActors::NLog::PRI_INFO, pm);

Expand Down Expand Up @@ -178,6 +179,8 @@ namespace NKafka::NTests {
ui16 kafkaPort = pm->GetPort();
auto serverSettings = NPersQueueTests::PQSettings(0).SetDomainName("Root").SetNodeCount(1);
serverSettings.AppConfig->MutableKafkaProxyConfig()->SetEnableKafkaProxy(true);
serverSettings.AppConfig->MutableKafkaProxyConfig()->SetEnableEndpointDiscovery(true);

serverSettings.AppConfig->MutableKafkaProxyConfig()->SetListeningPort(kafkaPort);
NPersQueue::TTestServer server(serverSettings, true, {}, NActors::NLog::PRI_INFO, pm);

Expand Down
1 change: 1 addition & 0 deletions ydb/core/kafka_proxy/ut/ut_protocol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ class TTestServer {
cst->SetName("data-transfer2");

appConfig.MutableKafkaProxyConfig()->SetEnableKafkaProxy(true);
appConfig.MutableKafkaProxyConfig()->SetEnableEndpointDiscovery(true);
appConfig.MutableKafkaProxyConfig()->SetListeningPort(Port);
appConfig.MutableKafkaProxyConfig()->SetMaxMessageSize(1024);
appConfig.MutableKafkaProxyConfig()->SetMaxInflightSize(2048);
Expand Down
1 change: 1 addition & 0 deletions ydb/core/protos/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2085,6 +2085,7 @@ message TKafkaProxyConfig {

optional TProxy Proxy = 7;
optional bool MeteringV2Enabled = 10 [default = false];
optional bool EnableEndpointDiscovery = 11 [default = false];
}

message TAwsCompatibilityConfig {
Expand Down

0 comments on commit 8edbfd6

Please sign in to comment.