Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column CreatedAt to table Sids schemeshard localdb #13044

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

molotkov-and
Copy link
Collaborator

Changelog entry

New column CreatedAt was added to schemeshard localdb in table Sids

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Dec 26, 2024

2024-12-26 14:15:13 UTC Pre-commit check linux-x86_64-release-asan for 1db13b4 has started.
2024-12-26 14:15:38 UTC Artifacts will be uploaded here
2024-12-26 14:19:04 UTC ya make is running...
🟡 2024-12-26 15:53:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13420 13336 0 37 17 30

2024-12-26 15:55:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 16:07:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 107 0 4 0 25

2024-12-26 16:07:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-26 16:19:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56 (only retried tests) 28 0 3 0 25

🟢 2024-12-26 16:19:51 UTC Build successful.
🟢 2024-12-26 16:20:23 UTC ydbd size 3.6 GiB changed* by +23.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ed3ebdd merge: 1db13b4 diff diff %
ydbd size 3 867 825 696 Bytes 3 867 849 616 Bytes +23.4 KiB +0.001%
ydbd stripped size 1 348 720 528 Bytes 1 348 729 264 Bytes +8.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 26, 2024

2024-12-26 14:17:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1db13b4 has started.
2024-12-26 14:18:05 UTC Artifacts will be uploaded here
2024-12-26 14:21:31 UTC ya make is running...
🟡 2024-12-26 16:28:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31304 28337 0 7 2838 122

2024-12-26 16:32:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 16:43:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 76 0 1 0 117

2024-12-26 16:44:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-26 16:48:36 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ed3ebdd merge: 1db13b4 diff diff %
ydbd size 2 240 663 368 Bytes 2 240 684 280 Bytes +20.4 KiB +0.001%
ydbd stripped size 471 820 016 Bytes 471 826 288 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-26 16:48:38 UTC Check cancelled

@@ -1634,6 +1634,7 @@ struct Schema : NIceDb::Schema {
struct LastSuccessfulAttempt : Column<4, NScheme::NTypeIds::Timestamp> {};
struct LastFailedAttempt : Column<5, NScheme::NTypeIds::Timestamp> {};
struct FailedAttemptCount : Column<6, NScheme::NTypeIds::Uint32> {using Type = ui32; static constexpr Type Default = 0;};
struct CreatedAt : Column<7, NScheme::NTypeIds::Uint64> {};
Copy link
Member

@kunga kunga Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему не Timestamp?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделал по аналогии с struct ExpiresAt : Column<3, NScheme::NTypeIds::Uint64> {};

Copy link
Member

@kunga kunga Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дак вон там

struct LastFailedAttempt : Column<5, NScheme::NTypeIds::Timestamp> {}

Не удобно потом ui64 рисовать будет)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поменял на Timestamp

Copy link

github-actions bot commented Dec 26, 2024

2024-12-26 16:52:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2bbae2c has started.
2024-12-26 16:52:49 UTC Artifacts will be uploaded here
2024-12-26 16:56:19 UTC ya make is running...
🟡 2024-12-26 18:19:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31528 28558 0 9 2839 122

2024-12-26 18:22:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 18:34:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 75 0 1 0 118

2024-12-26 18:34:37 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-26 18:46:10 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 53 0 1 0 118

🟢 2024-12-26 18:46:17 UTC Build successful.
🟢 2024-12-26 18:46:39 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d90bd31 merge: 2bbae2c diff diff %
ydbd size 2 240 794 224 Bytes 2 240 815 120 Bytes +20.4 KiB +0.001%
ydbd stripped size 471 821 552 Bytes 471 827 824 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 26, 2024

2024-12-26 16:52:55 UTC Pre-commit check linux-x86_64-release-asan for 2bbae2c has started.
2024-12-26 16:53:06 UTC Artifacts will be uploaded here
2024-12-26 16:56:30 UTC ya make is running...
🟡 2024-12-26 17:56:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13644 13576 0 31 8 29

2024-12-26 17:57:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 18:09:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 82 0 5 1 25

2024-12-26 18:09:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-26 18:21:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 30 0 3 0 25

🟢 2024-12-26 18:21:21 UTC Build successful.
🟢 2024-12-26 18:21:51 UTC ydbd size 3.6 GiB changed* by +23.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d90bd31 merge: 2bbae2c diff diff %
ydbd size 3 868 042 024 Bytes 3 868 066 000 Bytes +23.4 KiB +0.001%
ydbd stripped size 1 348 729 296 Bytes 1 348 738 096 Bytes +8.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 10:35:20 UTC Pre-commit check linux-x86_64-release-asan for b550d22 has started.
2024-12-27 10:35:31 UTC Artifacts will be uploaded here
2024-12-27 10:38:50 UTC ya make is running...
🟡 2024-12-27 12:15:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13645 13579 0 30 5 31

2024-12-27 12:17:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 12:29:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 78 0 5 0 25

2024-12-27 12:29:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 12:35:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 32 0 2 0 24

🟢 2024-12-27 12:35:35 UTC Build successful.
🟢 2024-12-27 12:36:04 UTC ydbd size 3.6 GiB changed* by +19.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: df406e3 merge: b550d22 diff diff %
ydbd size 3 869 466 664 Bytes 3 869 486 504 Bytes +19.4 KiB +0.001%
ydbd stripped size 1 349 124 720 Bytes 1 349 129 360 Bytes +4.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 10:35:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for b550d22 has started.
2024-12-27 10:35:55 UTC Artifacts will be uploaded here
2024-12-27 10:39:21 UTC ya make is running...
🟡 2024-12-27 12:07:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31528 28560 0 8 2836 124

2024-12-27 12:10:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 12:23:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 73 0 1 0 120

2024-12-27 12:23:39 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-27 12:35:22 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 56 0 1 0 119

🟢 2024-12-27 12:35:29 UTC Build successful.
🟢 2024-12-27 12:35:52 UTC ydbd size 2.1 GiB changed* by +16.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: df406e3 merge: b550d22 diff diff %
ydbd size 2 241 665 856 Bytes 2 241 682 640 Bytes +16.4 KiB +0.001%
ydbd stripped size 471 947 344 Bytes 471 949 488 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 11:21:42 UTC Pre-commit check linux-x86_64-release-asan for a2f6cf6 has started.
2024-12-28 11:21:55 UTC Artifacts will be uploaded here
2024-12-28 11:25:12 UTC ya make is running...
2024-12-28 12:02:42 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 11:21:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for a2f6cf6 has started.
2024-12-28 11:22:01 UTC Artifacts will be uploaded here
2024-12-28 11:25:25 UTC ya make is running...
2024-12-28 12:02:40 UTC Check cancelled

@molotkov-and molotkov-and linked an issue Dec 28, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 12:06:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 322052f has started.
2024-12-28 12:07:00 UTC Artifacts will be uploaded here
2024-12-28 12:10:17 UTC ya make is running...
🟡 2024-12-28 13:37:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22879 22289 0 8 461 121

2024-12-28 13:39:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 13:51:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 68 0 1 0 120

2024-12-28 13:51:29 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-28 14:03:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 55 0 1 0 120

🟢 2024-12-28 14:03:15 UTC Build successful.
🟢 2024-12-28 14:03:38 UTC ydbd size 2.1 GiB changed* by +16.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e1ce008 merge: 322052f diff diff %
ydbd size 2 242 053 384 Bytes 2 242 069 936 Bytes +16.2 KiB +0.001%
ydbd stripped size 472 101 744 Bytes 472 103 792 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 12:07:27 UTC Pre-commit check linux-x86_64-release-asan for 322052f has started.
2024-12-28 12:07:38 UTC Artifacts will be uploaded here
2024-12-28 12:10:51 UTC ya make is running...
🟡 2024-12-28 13:32:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13647 13574 0 34 11 28

2024-12-28 13:34:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 13:46:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 90 0 6 2 25

2024-12-28 13:47:02 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-28 13:58:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 30 0 4 1 25

🟢 2024-12-28 13:58:46 UTC Build successful.
🟢 2024-12-28 13:59:16 UTC ydbd size 3.6 GiB changed* by +23.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e1ce008 merge: 322052f diff diff %
ydbd size 3 870 467 528 Bytes 3 870 491 144 Bytes +23.1 KiB +0.001%
ydbd stripped size 1 349 997 072 Bytes 1 350 005 744 Bytes +8.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 09:34:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 05f2109 has started.
2025-01-13 09:34:36 UTC Artifacts will be uploaded here
2025-01-13 09:37:56 UTC ya make is running...
🟡 2025-01-13 11:00:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27678 25172 0 3 2380 123

2025-01-13 11:03:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-13 11:15:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 65 0 1 0 119

2025-01-13 11:15:27 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-13 11:30:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 56 0 0 0 118

🟢 2025-01-13 11:30:43 UTC Build successful.
🟢 2025-01-13 11:31:04 UTC ydbd size 2.1 GiB changed* by +16.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d61f688 merge: 05f2109 diff diff %
ydbd size 2 245 779 304 Bytes 2 245 795 840 Bytes +16.1 KiB +0.001%
ydbd stripped size 472 620 976 Bytes 472 623 024 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 13, 2025

2025-01-13 09:35:09 UTC Pre-commit check linux-x86_64-release-asan for 05f2109 has started.
2025-01-13 09:35:21 UTC Artifacts will be uploaded here
2025-01-13 09:38:55 UTC ya make is running...
🟡 2025-01-13 11:14:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13671 13616 0 21 6 28

2025-01-13 11:16:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-13 11:32:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 64 0 0 0 28

🟢 2025-01-13 11:32:18 UTC Build successful.
🟢 2025-01-13 11:32:56 UTC ydbd size 3.6 GiB changed* by +23.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d61f688 merge: 05f2109 diff diff %
ydbd size 3 893 504 640 Bytes 3 893 528 200 Bytes +23.0 KiB +0.001%
ydbd stripped size 1 360 179 376 Bytes 1 360 188 016 Bytes +8.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit 140146f into ydb-platform:main Jan 14, 2025
12 checks passed
@molotkov-and molotkov-and deleted the add-createdAt-column branch January 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add field CreatedAt to schemeshard local db
4 participants