Default compression setting via CS config #13203
Conversation
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
vlad-gogov
force-pushed
the
validate_compression_from_cs_config
branch
from
459a77f to
2bb005a
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (!columnShardConfig.HasDefaultCompression() && !columnShardConfig.HasDefaultCompressionLevel()) { | ||
| return EValidationResult::Ok; | ||
| } | ||
| if (!columnShardConfig.HasDefaultCompression() && columnShardConfig.HasDefaultCompressionLevel()) { |
There was a problem hiding this comment.
Такая же логика валидации есть в десериалайзере family. По-моему, этот код надо переиспользовать, чтобы валидация была реализована только один раз.
| } | ||
| std::optional<arrow::Compression::type> codec = NArrow::CompressionFromProto(columnShardConfig.GetDefaultCompression()); | ||
| if (!codec.has_value()) { | ||
| msg.push_back("ColumnShardConfig: Unknown compression"); |
There was a problem hiding this comment.
Зачем собирать сообщения об ошибках в вектор? Не будет лучше подходить TConclusionStatus: возвращается либо провал валидации и сообщение, либо успех?
| if (validateDefaultCompressionResult == EValidationResult::Error) { | ||
| return EValidationResult::Error; | ||
| } | ||
| if (msg.size() > 0) { |
There was a problem hiding this comment.
Если в msg заранее были сообщения, то ValidateColumnShardConfig будет возвращать WARN, что, кажется, неожиданно. Зачем этот случай вообще обрабатывается?
| if (!arrow::util::Codec::SupportsCompressionLevel(compression)) { | ||
| return false; | ||
| } | ||
| if (compressionLevel.has_value()) { |
There was a problem hiding this comment.
Кажется, этот код дублируется в десериализайзере family. Его можно переиспользовать?
Changelog entry
Default compression setting via CS config and its validation
Changelog category