-
Notifications
You must be signed in to change notification settings - Fork 695
YQ added unit test for block insert #19742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ added unit test for block insert #19742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new unit test to verify block insert behavior when inserting a null column.
- Introduces the TestBlockInsertNullColumn unit test.
- Sets the table service to force block channels and exercises external data source queries for block insert with a null column.
Comments suppressed due to low confidence (1)
ydb/core/kqp/ut/federated_query/s3/kqp_federated_query_ut.cpp:2655
- The unit test currently checks that the block insert query completes successfully, but it does not verify that the null column is handled as expected. Consider adding assertions to explicitly validate the outcome of the null value in the resulting data.
AS_TABLE([<|key: 1, value: Nothing(Optional<String>)|>]);
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢 |
Changelog entry
Added unit test for block insert
Changelog category
Description for reviewers