Skip to content

YQ added unit test for block insert #19742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Added unit test for block insert

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@GrigoriyPA GrigoriyPA requested a review from uzhastik June 17, 2025 12:36
@GrigoriyPA GrigoriyPA requested a review from a team as a code owner June 17, 2025 12:36
@GrigoriyPA GrigoriyPA requested a review from Copilot June 17, 2025 12:36
Copy link

github-actions bot commented Jun 17, 2025

2025-06-17 12:36:51 UTC Pre-commit check linux-x86_64-release-asan for cf63365 has started.
2025-06-17 12:36:55 UTC Artifacts will be uploaded here
2025-06-17 12:39:24 UTC ya make is running...
2025-06-17 12:40:54 UTC Check cancelled

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new unit test to verify block insert behavior when inserting a null column.

  • Introduces the TestBlockInsertNullColumn unit test.
  • Sets the table service to force block channels and exercises external data source queries for block insert with a null column.
Comments suppressed due to low confidence (1)

ydb/core/kqp/ut/federated_query/s3/kqp_federated_query_ut.cpp:2655

  • The unit test currently checks that the block insert query completes successfully, but it does not verify that the null column is handled as expected. Consider adding assertions to explicitly validate the outcome of the null value in the resulting data.
                AS_TABLE([<|key: 1, value: Nothing(Optional<String>)|>]);

Copy link

🟢 2025-06-17 12:37:24 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 17, 2025

2025-06-17 12:39:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for cf63365 has started.
2025-06-17 12:39:34 UTC Artifacts will be uploaded here
2025-06-17 12:40:51 UTC Check cancelled

Copy link

github-actions bot commented Jun 17, 2025

2025-06-17 12:42:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3de1fd8 has started.
2025-06-17 12:42:44 UTC Artifacts will be uploaded here
2025-06-17 12:45:05 UTC ya make is running...
🟢 2025-06-17 13:11:36 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 48 0 0 0 0

🟢 2025-06-17 13:11:43 UTC Build successful.

Copy link

github-actions bot commented Jun 17, 2025

2025-06-17 12:42:46 UTC Pre-commit check linux-x86_64-release-asan for 3de1fd8 has started.
2025-06-17 12:42:58 UTC Artifacts will be uploaded here
2025-06-17 12:45:35 UTC ya make is running...
🟢 2025-06-17 13:13:46 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-06-17 13:13:52 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant