Skip to content

Add describe consumer group for akhq #19768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add describe consumer group for akhq #19768

wants to merge 10 commits into from

Conversation

nerhneiro
Copy link
Collaborator

Changelog entry

Create TKafksDescribeConsumerGroup

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Irina Skvortsova added 9 commits May 16, 2025 16:13
generate TListGroupRequestData and TListGroupResponseData classes, EA…
a6eb513 
…piKey::LIST_GROUPS
add actor files, generate TListGroupsResponseData and TListGroupsRequ…
c1baced 
…estData in kaffka_messages.h

write test to check is ListGroupsActor works correctly
add statesFilter realization
8b78201 
add new test
Merge branch 'add-list-groups-for-akhq' into add-describe-consumer-gr…
ae62f53 
…oup-for-akhq
generate DESCRIBE_GROUPS in kafka_messages
579b5b7
add correct DatabasePath from context
fc672fa 
add check on EnableKafkaNativeBalancing feature flag existance
add empty check in up_protocol.cpp
correct codestyle
delete excesive variables
add comments
add ApiKey for LIST_GROUPS
5ffef6b 
change error check from NOT_FOUND to SCHEME_ERROR
Merge branch 'add-list-groups-for-akhq' into add-describe-consumer-gr…
5b33b20 
…oup-for-akhq
add DescribeGroups actor
d03f06d 
shift numbersToStatesMapping and statesToNumbersMapping into a separate file
add test for DescribeGroups in ut_protocol.cpp
@nerhneiro nerhneiro requested a review from a team as a code owner June 17, 2025 16:03
@nerhneiro nerhneiro requested review from qyryq and a-serebryanskiy and removed request for qyryq June 17, 2025 16:03
@github-actions GitHub Actions
Copy link

🟢 2025-06-17 16:04:56 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

⚪ 2025-06-17 16:10:18 UTC Pre-commit check linux-x86_64-release-asan for d245305 has started.
⚪ 2025-06-17 16:10:29 UTC Artifacts will be uploaded here
⚪ 2025-06-17 16:13:39 UTC ya make is running...
🟡 2025-06-17 17:52:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15492 15303 0 91 76 22

⚪ 2025-06-17 17:54:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-17 18:27:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1534 (only retried tests) 1384 0 71 59 20

⚪ 2025-06-17 18:27:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-17 19:01:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1409 (only retried tests) 1309 0 62 22 16

🟢 2025-06-17 19:02:04 UTC Build successful.
🟡 2025-06-17 19:02:38 UTC ydbd size 3.9 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63c2e1f merge: d245305 diff diff %
ydbd size 4 172 756 736 Bytes 4 174 570 448 Bytes +1.7 MiB +0.043%
ydbd stripped size 1 447 005 752 Bytes 1 447 450 872 Bytes +434.7 KiB +0.031%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2025 •
edited
Loading

⚪ 2025-06-17 16:10:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for d245305 has started.
⚪ 2025-06-17 16:10:34 UTC Artifacts will be uploaded here
⚪ 2025-06-17 16:13:55 UTC ya make is running...
🟡 2025-06-17 17:33:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30711 29279 0 22 1359 51

⚪ 2025-06-17 17:36:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-17 17:47:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
652 (only retried tests) 613 0 12 2 25

⚪ 2025-06-17 17:47:43 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-17 17:58:25 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
297 (only retried tests) 263 0 12 0 22

🟢 2025-06-17 17:58:35 UTC Build successful.
🟡 2025-06-17 17:59:02 UTC ydbd size 2.2 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63c2e1f merge: d245305 diff diff %
ydbd size 2 372 422 808 Bytes 2 373 483 712 Bytes +1.0 MiB +0.045%
ydbd stripped size 497 436 424 Bytes 497 584 392 Bytes +144.5 KiB +0.030%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

a-serebryanskiy
a-serebryanskiy reviewed Jun 18, 2025
View reviewed changes
add correct dying
5ae6061 
change order of methods
change ApiKeys.size() check from 18 to 20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

⚪ 2025-06-18 13:58:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2c6f3c0 has started.
⚪ 2025-06-18 13:59:09 UTC Artifacts will be uploaded here
⚪ 2025-06-18 14:02:28 UTC ya make is running...
🟡 2025-06-18 15:23:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30731 29336 0 5 1346 44

⚪ 2025-06-18 15:26:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-18 15:38:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
316 (only retried tests) 292 0 1 0 23

⚪ 2025-06-18 15:39:04 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-06-18 15:50:14 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
280 (only retried tests) 255 0 1 0 24

🟢 2025-06-18 15:50:22 UTC Build successful.
🟡 2025-06-18 15:50:46 UTC ydbd size 2.2 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 38bd366 merge: 2c6f3c0 diff diff %
ydbd size 2 373 172 192 Bytes 2 374 337 680 Bytes +1.1 MiB +0.049%
ydbd stripped size 497 552 456 Bytes 497 725 416 Bytes +168.9 KiB +0.035%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

⚪ 2025-06-18 13:59:06 UTC Pre-commit check linux-x86_64-release-asan for 2c6f3c0 has started.
⚪ 2025-06-18 13:59:17 UTC Artifacts will be uploaded here
⚪ 2025-06-18 14:02:36 UTC ya make is running...
🟡 2025-06-18 16:12:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15510 15234 0 102 147 27

⚪ 2025-06-18 16:13:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-18 16:47:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1640 (only retried tests) 1382 0 79 157 22

⚪ 2025-06-18 16:48:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-18 17:21:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1496 (only retried tests) 1230 0 80 164 22

🟢 2025-06-18 17:22:01 UTC Build successful.
🟡 2025-06-18 17:22:35 UTC ydbd size 3.9 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0808af4 merge: 2c6f3c0 diff diff %
ydbd size 4 174 298 976 Bytes 4 176 065 640 Bytes +1.7 MiB +0.042%
ydbd stripped size 1 447 457 720 Bytes 1 447 882 776 Bytes +415.1 KiB +0.029%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-serebryanskiy a-serebryanskiy a-serebryanskiy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nerhneiro @a-serebryanskiy