Skip to content

Add lrpc commit offset handler main #26698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Add lrpc commit offset handler main #26698

wants to merge 11 commits into from

Conversation

nerhneiro
Copy link
Collaborator

Changelog entry

Add offset commit json handler.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nerhneiro nerhneiro requested review from a team as code owners October 10, 2025 15:53
@nerhneiro nerhneiro marked this pull request as draft October 10, 2025 15:53
@nerhneiro nerhneiro removed the request for review from Alek5andr-Kotov October 10, 2025 15:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

⚪ 2025-10-10 15:55:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b7ceea has started.
⚪ 2025-10-10 15:55:19 UTC Artifacts will be uploaded here
⚪ 2025-10-10 15:59:46 UTC ya make is running...
🟡 2025-10-10 18:26:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41737 38940 0 7 2757 33

⚪ 2025-10-10 18:27:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-10 18:49:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
733 (only retried tests) 702 0 4 1 26

⚪ 2025-10-10 18:49:34 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-10 19:05:49 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
553 (only retried tests) 524 0 3 1 25

🟢 2025-10-10 19:05:52 UTC Build successful.
🟢 2025-10-10 19:06:14 UTC ydbd size 2.3 GiB changed* by -50.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 21a2666 merge: 8b7ceea diff diff %
ydbd size 2 419 246 600 Bytes 2 419 195 424 Bytes -50.0 KiB -0.002%
ydbd stripped size 515 277 544 Bytes 515 270 088 Bytes -7.3 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

⚪ 2025-10-10 16:04:11 UTC Pre-commit check linux-x86_64-release-asan for 8b7ceea has started.
⚪ 2025-10-10 16:04:25 UTC Artifacts will be uploaded here
⚪ 2025-10-10 16:08:38 UTC ya make is running...
🟡 2025-10-10 19:00:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18586 18139 0 164 252 31

🟢 2025-10-10 19:00:47 UTC Build successful.
🟢 2025-10-10 19:01:11 UTC ydbd size 3.7 GiB changed* by +30.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 21a2666 merge: 8b7ceea diff diff %
ydbd size 4 024 311 984 Bytes 4 024 343 624 Bytes +30.9 KiB +0.001%
ydbd stripped size 1 494 692 384 Bytes 1 494 839 840 Bytes +144.0 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

🟢 2025-10-10 16:06:29 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 11:30:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc27258 has started.
⚪ 2025-10-13 11:30:40 UTC Artifacts will be uploaded here
⚫ 2025-10-13 11:34:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 11:30:29 UTC Pre-commit check linux-x86_64-release-asan for cc27258 has started.
⚪ 2025-10-13 11:30:43 UTC Artifacts will be uploaded here
⚫ 2025-10-13 11:34:03 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 11:36:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for d23e8e6 has started.
⚪ 2025-10-13 11:36:26 UTC Artifacts will be uploaded here
⚫ 2025-10-13 11:37:06 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 11:36:30 UTC Pre-commit check linux-x86_64-release-asan for d23e8e6 has started.
⚪ 2025-10-13 11:36:43 UTC Artifacts will be uploaded here
⚫ 2025-10-13 11:37:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 11:38:39 UTC Pre-commit check linux-x86_64-release-asan for 0eded98 has started.
⚪ 2025-10-13 11:38:52 UTC Artifacts will be uploaded here
⚪ 2025-10-13 11:42:30 UTC ya make is running...
⚫ 2025-10-13 12:25:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 11:38:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0eded98 has started.
⚪ 2025-10-13 11:38:53 UTC Artifacts will be uploaded here
⚪ 2025-10-13 11:42:38 UTC ya make is running...
⚫ 2025-10-13 12:25:58 UTC Check cancelled

alexnick88
alexnick88 previously approved these changes Oct 13, 2025
View reviewed changes
alexnick88
alexnick88 reviewed Oct 13, 2025
View reviewed changes
ydb/services/persqueue_v1/topic.cpp Outdated

ADD_REQUEST(CommitOffset, TopicService, CommitOffsetRequest, CommitOffsetResponse, {
ActorSystem_->Send(GRpcRequestProxyId_, new NGRpcService::TEvCommitOffsetRequest(ctx));
ActorSystem_->Send(GRpcRequestProxyId_, new NGRpcService::TEvCommitOffsetRequest(ctx, &DoCommitOffsetRequest, TRequestAuxSettings{.RlMode = RLSWITCH(TRateLimiterMode::Rps), .AuditMode = TAuditMode::Modifying(TAuditMode::TLogClassConfig::Ddl), .RequestType = NJaegerTracing::ERequestType::TOPIC_COMMITOFFSET}));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут неправильные параметры - это не TLogClassConfig::Ddl, это Dml

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 12:39:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3336180 has started.
⚪ 2025-10-13 12:39:16 UTC Artifacts will be uploaded here
⚪ 2025-10-13 12:43:09 UTC ya make is running...
⚫ 2025-10-13 12:44:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 12:47:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a31322 has started.
⚪ 2025-10-13 12:48:01 UTC Artifacts will be uploaded here
⚪ 2025-10-13 12:52:02 UTC ya make is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

⚪ 2025-10-13 13:01:44 UTC Pre-commit check linux-x86_64-release-asan for 8a31322 has started.
⚪ 2025-10-13 13:02:23 UTC Artifacts will be uploaded here
⚪ 2025-10-13 13:06:26 UTC ya make is running...
🟡 2025-10-13 15:04:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17603 17163 0 162 252 26

🟢 2025-10-13 15:04:33 UTC Build successful.
🟢 2025-10-13 15:04:57 UTC ydbd size 3.7 GiB changed* by -200.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ff2b01d merge: 8a31322 diff diff %
ydbd size 4 025 781 648 Bytes 4 025 576 800 Bytes -200.0 KiB -0.005%
ydbd stripped size 1 495 229 728 Bytes 1 495 165 984 Bytes -62.2 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nerhneiro @alexnick88