Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null value for correct dataset #220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matheus1lva
Copy link
Contributor

@matheus1lva matheus1lva commented Mar 9, 2025

solve #212

Copy link

vercel bot commented Mar 9, 2025

@matheus1lva is attempting to deploy a commit to the MOM Team on Vercel.

A member of the Team first needs to authorize it.

@matheus1lva
Copy link
Contributor Author

cc @murderteeth

Copy link
Collaborator

@murderteeth murderteeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to think about this a bit more. for example,

tvl resolver / prices

it's ok to replace 0 with null (but note, its' not ok to replace 0 x null for the value field)

timerseries resolver

right now we have these timeseries: APY, TVL, PPS. for PPS it's ok to replace 0 x null. but not ok for APY or TVL.

instead of replacing 0 x null in the resolvers, we may need to make updates at the sources. for example, look at TVL code and make sure it only logs 0 when it should really be 0.

but! i reviewed the ticket and see the user specifically had an issue with prices on the tvl resolver. so i think we're good actually! lets just delete the 0 x null logic in the timeseries resolver. when we have time, we can review the 0 vs null logic at the different timeseries sources and make sure logic looks sound.

@matheus1lva matheus1lva changed the title fix: tvl shows value as null fix: null value for correct dataset Mar 11, 2025
@matheus1lva
Copy link
Contributor Author

Given that explanation and what we came to agree on, i've done the following changes:

  1. PPS for timeseries returns null since it is plausible and fits much more into the context
  2. TVL on the resolver is going to return null
  3. TVL on yearn hooks i've added a check for the price to never be null (just in case).

I think we are good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants