Update BaseFeeOracle.sol: Reduction of extra Slot #562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current file, state variables were arranged in this form:
After the changes:
With this one slot got reduced, cuz each slot can take upto 32 bytes whereas address covers up 20 bytes of space and bool takes up 1 byte. Thus, they both will be assigned into 1 slot i.e slot 4
For Further Explaination: link
Although, there was one more doubt related to
bool public manualBaseFeeBool;
, this variable will always be set to true in the constructor itself..Then why we don't just removemanualBaseFeeBool = true;
from the constructor and change the initialization tobool public manualBaseFeeBool = true;
. Why to add an extra line of code?Thanks!