update addEngagementByBlock method to store reliableByBlock attribute for block-scoped assessments #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richford
requested changes
Jan 30, 2024
There was a problem hiding this comment.
I like adding the reliableByBlock param, but could this just be added to the existing addEngagementFlags method, by supplying reliableByBlock as an optional parameter and only updating it in firestore if it is non-empty? Are there any drawbacks to that that I'm not seeing?
lucasxsong
force-pushed
the
enh/add-reliable-by-block
branch
from
348a8f2 to
0e7675f
Compare
That's a good point. I've updated the addEngagementFlag method to instead take in the reliableByBlock as an optional parameter to reduce duplication of code. |
lucasxsong
changed the title
lucasxsong
changed the title
richford
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
updateEngagementFlagsByBlockmethod is similar to theupdateEngagementFlagspreviously declared, but adds on functionality to update thereliableByBlockattribute under runs. This attribute is a dictionary that allows for indication of reliability by block.