TASK: Tweak retrieval of GraylogService in Exception handler

yeebase · Apr 25, 2017 · 046fb71 · 046fb71
1 parent 30629eb
commit 046fb71
Showing 1 changed file with 20 additions and 11 deletions.
diff --git a/Classes/Error/GraylogExceptionHandler.php b/Classes/Error/GraylogExceptionHandler.php
@@ -8,6 +8,7 @@
 
 use Neos\Flow\Annotations as Flow;
 use Neos\Flow\Error\ProductionExceptionHandler;
+use Neos\Flow\ObjectManagement\DependencyInjection\DependencyProxy;
 use Yeebase\Graylog\GraylogService;
 
 /**
@@ -28,13 +29,8 @@ class GraylogExceptionHandler extends ProductionExceptionHandler
      */
     protected function echoExceptionWeb($exception)
     {
-
-        if ($this->graylogService === null) {
-            $this->graylogService = new GraylogService();
-        }
-
         if (isset($this->renderingOptions['logException']) && $this->renderingOptions['logException']) {
-            $this->graylogService->logException($exception);
+            $this->getGraylogService()->logException($exception);
         }
 
         parent::echoExceptionWeb($exception);
@@ -46,14 +42,27 @@ protected function echoExceptionWeb($exception)
      */
     protected function echoExceptionCli($exception)
     {
-        if ($this->graylogService === null) {
-            $this->graylogService = new GraylogService();
-        }
-
         if (isset($this->renderingOptions['logException']) && $this->renderingOptions['logException']) {
-            $this->graylogService->logException($exception);
+            $this->getGraylogService()->logException($exception);
         }
 
         parent::echoExceptionCli($exception);
     }
+
+    /**
+     * Returns an instance of the injected GraylogService (including a fallback to a manually instantiated instance
+     * if Dependency Injection is not (yet) available)
+     *
+     * @return GraylogService
+     */
+    private function getGraylogService()
+    {
+        if ($this->graylogService instanceof GraylogService) {
+            return $this->graylogService;
+        } elseif ($this->graylogService instanceof DependencyProxy) {
+            return $this->graylogService->_activateDependency();
+        } else {
+            return new GraylogService();
+        }
+    }
 }