Skip to content
This repository has been archived by the owner on May 3, 2019. It is now read-only.

Commit

Permalink
Don’t change method signature for allowsCallOfMethods in Eel-Helper c…
Browse files Browse the repository at this point in the history
…lasses
  • Loading branch information
johannessteu committed Jan 21, 2019
2 parents 40f0cc0 + 13e1125 commit cb1ba8e
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
5 changes: 4 additions & 1 deletion Classes/Eel/Helper/ChainHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ public function getCombinedErrorMessages(): string
return implode(PHP_EOL, $messages);
}

public function allowsCallOfMethod(string $methodName): bool
/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
*/
public function allowsCallOfMethod($methodName): bool
{
return $this->runtime->isTaskContext();
}
Expand Down
5 changes: 4 additions & 1 deletion Classes/Eel/Helper/LockHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ public function isUnset(string $lockName): bool
return ! $this->isSet($lockName);
}

public function allowsCallOfMethod(string $methodName): bool
/**
* @phpcsSuppress SlevomatCodingStandard.TypeHints.TypeHintDeclaration.MissingParameterTypeHint
*/
public function allowsCallOfMethod($methodName): bool
{
return substr($methodName, 0, 2) === 'is' || $this->runtime->isTaskContext();
}
Expand Down
5 changes: 5 additions & 0 deletions Configuration/Settings.Reflection.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Neos:
Flow:
reflection:
ignoredTags:
'phpcsSuppress': TRUE

0 comments on commit cb1ba8e

Please sign in to comment.