Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Add RedirectMiddleware and make Flow/Neos 7 compatible #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TASK: Add RedirectMiddleware and make Flow/Neos 7 compatible #8

wants to merge 2 commits into from

Conversation

gerdemann
Copy link

No description provided.

@gerdemann gerdemann mentioned this pull request Apr 14, 2022
Closed
4 tasks
bwaidelich
bwaidelich previously approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (by reading)

albe
albe previously approved these changes Apr 14, 2022
View reviewed changes
Copy link

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree to what Bastian wrote in the old PR. Reads good from what I can see. Thanks a lot for taking it up!

composer.json Outdated Show resolved Hide resolved
@gerdemann gerdemann dismissed stale reviews from albe and bwaidelich via a9e77f4 April 14, 2022 10:00
@gerdemann @albe
feat: Add Neos 8 support
a9e77f4 
Co-authored-by: Alexander Berl <[email protected]>
Benjamin-K
Benjamin-K approved these changes Sep 27, 2022
View reviewed changes
Copy link

@Benjamin-K Benjamin-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged, IMO.

Benjamin-K
Benjamin-K approved these changes Sep 27, 2022
View reviewed changes
Copy link

@Benjamin-K Benjamin-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry, forgot to check viewed files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin-K Benjamin-K Benjamin-K approved these changes

@bwaidelich bwaidelich bwaidelich left review comments

@albe albe albe left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gerdemann @bwaidelich @Benjamin-K @albe