Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark expired cfp as closed #67

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

blablatdinov
Copy link
Contributor

ref: #64

@blablatdinov
Copy link
Contributor Author

@yegor256 Try rerun workflow manually, pls. Tests fail because code coverege down. However, locally I take 100% test coverage

@blablatdinov
Copy link
Contributor Author

blablatdinov commented Jul 19, 2024

@yegor256 sorry, tests.sh run update fixtures dir and mark expired dates as closed, so python tests not check expired date case. Take a look

@yegor256
Copy link
Owner

@blablatdinov do I understand correctly that the conferences with expired "cfp" won't be rendered in the table at all?

@blablatdinov
Copy link
Contributor Author

@yegor256 No, trey are rendered as "closed", check test case

@yegor256 yegor256 merged commit a1d5bdf into yegor256:master Jul 19, 2024
8 checks passed
@yegor256
Copy link
Owner

@blablatdinov thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants