#704 - Enforce failure reasons in tests #899
Conversation
|
Job #899 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=========================================
Coverage 87.09% 87.09%
Complexity 1457 1457
=========================================
Files 259 259
Lines 3773 3773
Branches 212 212
=========================================
Hits 3286 3286
Misses 439 439
Partials 48 48Continue to review full report at Codecov.
|
|
@neonailol please use the maven configuration merged in #882. |
|
@llorllale updated |
pom.xml
Outdated
| @@ -156,7 +156,7 @@ The MIT License (MIT) | |||
| --> | |||
| <failOnViolation>false</failOnViolation> | |||
| <signaturesFiles> | |||
| <signaturesFile>./src/test/resources/forbidden-apis.txt</signaturesFile> | |||
| <signaturesFile>./src/verifier/forbiddenapis.txt</signaturesFile> | |||
There was a problem hiding this comment.
@neonailol why not use ./src/test/resources/forbidden-apis.txt like in #882
There was a problem hiding this comment.
@llorllale Because it is not part of sources, just like verifications.xml, and should not be in classpath
There was a problem hiding this comment.
@neonailol I don't understand. src/test/resources is exactly the path for these kinds of things. It won't be exported to production when released.
There was a problem hiding this comment.
@llorllale well src/test/resources as stated from the path, is the directory for resources used by tests, this, on the other hand, is the resources needed to perform static verification of all sources. I expect in the future someone will be using this to prohibit uses of some other methods in library code, not just the tests.
There was a problem hiding this comment.
@neonailol we'll do that when the need arises. For now, please put the file back in src/test/resources, thanks
|
@neonailol see my comment above |
|
@llorllale done, it is also worth to check out bundled with the plugin signatures |
|
@neonailol good to know, thanks |
|
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 10min) |
|
The job #899 is now out of scope |
Fix For #704
Same as PR #744 but only prints errors without failing the build