Move _postConstruct from create to instantiate. (#382)

yeoman · Jan 18, 2022 · 66752e4 · 66752e4
1 parent 256e142
commit 66752e4
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/lib/environment.js b/lib/environment.js
@@ -764,16 +764,10 @@ class Environment extends Base {
     };
 
     maybeGenerator = maybeGenerator || this.get(namespaceOrPath);
-    if (maybeGenerator && (maybeGenerator.then || maybeGenerator.prototype._postConstruct)) {
+    if (maybeGenerator && maybeGenerator.then) {
       return Promise.resolve(maybeGenerator)
         .then(Generator => checkGenerator(Generator))
-        .then(Generator => this.instantiate(Generator, args, options))
-        .then(async generator => {
-          if (!options.help && generator._postConstruct) {
-            await generator._postConstruct();
-          }
-          return generator;
-        });
+        .then(Generator => this.instantiate(Generator, args, options));
     }
 
     return this.instantiate(checkGenerator(maybeGenerator), args, options);
@@ -816,6 +810,10 @@ class Environment extends Base {
       ...environmentOptions
     };
 
+    if (!options.help && generator._postConstruct) {
+      return Promise.resolve(generator._postConstruct()).then(() => generator);
+    }
+
     return generator;
   }