Fix data race in loadAlignmentPatternLoc #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks good, and add a test case for it would be better. And further, is there a more performance way to resolve it? such as a precalculated state? reducing locked code block? |
|
@yeqown
Using a precalculated state could indeed be a more performance-efficient way to resolve this. |
yeqown
approved these changes
Apr 10, 2024
|
@mnrtks If "pre-calculated state" is not planned by you or this PR, this PR will be accepted and merged. |
|
@yeqown "pre-calculated state" is not planned in this PR. |
alexballas
pushed a commit
to alexballas/go-qrcode
that referenced
this pull request
May 25, 2024
* Fix data race in loadAlignmentPatternLoc * Add test for loadAlignmentPatternLoc with concurrent access * go test with -race flag
alexballas
pushed a commit
to alexballas/go-qrcode
that referenced
this pull request
May 25, 2024
* Fix data race in loadAlignmentPatternLoc * Add test for loadAlignmentPatternLoc with concurrent access * go test with -race flag
alexballas
pushed a commit
to alexballas/go-qrcode
that referenced
this pull request
May 25, 2024
* Fix data race in loadAlignmentPatternLoc * Add test for loadAlignmentPatternLoc with concurrent access * go test with -race flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #103