Parameterize prims by their numeric type and endianness #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce some duplication in
core::Prim
by adding fields determining a prim's int/float type and endianness where necessaryeg
FormatU64Be
becomesFormatInt(IntType::Unsigned(UintType::U64, Endianness::Big))
Allows removing a lot of repeated
match
arms all over the place. Still not as concise as I would like, but an improvement.