Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warp-tls: fixed typo in ChangeLog #942

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Oct 2, 2023

Changelog entry for 3.4.2 was copy-pasted and then not changed, so here's the fix.

@kazu-yamamoto Can you publish warp-tls-3.4.3 this after the merge? (since I've just merged in the 3.4.3 update before this fix)

@Vlix Vlix requested a review from kazu-yamamoto October 2, 2023 16:20
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kazu-yamamoto kazu-yamamoto merged commit a64c792 into yesodweb:master Oct 3, 2023
@Vlix Vlix deleted the fix/changelog-version-typo branch October 3, 2023 05:10
@Vlix
Copy link
Contributor Author

Vlix commented Oct 3, 2023

@kazu-yamamoto Do you think you could find the time to publish warp-tls-3.4.3 to hackage as well? Or do you and Michael maybe have certain schedules for doing so?

@kazu-yamamoto
Copy link
Contributor

kazu-yamamoto commented Oct 3, 2023

I have time. Do you want to release warp as well?

@Vlix
Copy link
Contributor Author

Vlix commented Oct 3, 2023

warp doesn't need to be published, does it? Just warp-tls

@kazu-yamamoto
Copy link
Contributor

If #940 is not urgent, the answer is "not need to be published".

@Vlix
Copy link
Contributor Author

Vlix commented Oct 3, 2023

I just merged in #915 today, so was wondering what the process was for publishing (since only you and Michael have publishing rights to warp-tls on hackage)

@kazu-yamamoto
Copy link
Contributor

I was talking about warp, not warp-tls.
I will release warp-tls since #915 was merged.
I asked whether or not we should release warp because of #940.

@kazu-yamamoto
Copy link
Contributor

warp-tls v3.4.3 has been released.

@Vlix
Copy link
Contributor Author

Vlix commented Oct 4, 2023

I was talking about warp, not warp-tls. I will release warp-tls since #915 was merged. I asked whether or not we should release warp because of #940.

Apologies, warp indeed doesn't need to be released. You mentioning it might have confused me, I think. Thanks for the release of warp-tls 👍

@kazu-yamamoto
Copy link
Contributor

My apologies for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants