fix(sdk): Partially verified batch should display results of processing #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uri-99
requested changes
Dec 23, 2024
uri-99
reviewed
Dec 23, 2024
uri-99
requested changes
Dec 23, 2024
Comment on lines
130
to
148
| if let SubmitError::InsufficientBalance(_, last_valid_nonce) = e { | ||
| aligned_submitted_data.push(Err(e)); | ||
| if last_valid_nonce < last_proof_nonce { | ||
| last_proof_nonce = last_valid_nonce; | ||
| } | ||
|
|
||
| if last_proof_nonce < first_nonce { | ||
| break; | ||
| } | ||
|
|
||
| continue; | ||
| } |
There was a problem hiding this comment.
this goes inside handle_batcher_response.
uri-99
reviewed
Dec 23, 2024
uri-99
reviewed
Dec 23, 2024
uri-99
reviewed
Dec 23, 2024
uri-99
reviewed
Dec 23, 2024
uri-99
reviewed
Dec 23, 2024
uri-99
reviewed
Dec 23, 2024
PatStiles
force-pushed
the
fix/partially-verified-batch-should-display-batches
branch
from
fff41d9 to
7b86ef7
Compare
uri-99
reviewed
Dec 30, 2024
uri-99
reviewed
Dec 30, 2024
uri-99
reviewed
Dec 30, 2024
| if let SubmitError::InsufficientBalance(_, error_nonce) = e { | ||
| aligned_submitted_data.push(Err(e)); | ||
|
|
||
| let last_valid_nonce = error_nonce - 1; |
There was a problem hiding this comment.
what happens when the first message is insufficient balance? maybe last_valid_nonce will underflow? (0-1 or similar)
uri-99
reviewed
Dec 30, 2024
Comment on lines
+143
to
+145
| if last_proof_nonce < first_nonce { | ||
| break; | ||
| } |
There was a problem hiding this comment.
i think this handles my previous comment
uri-99
reviewed
Dec 30, 2024
Comment on lines
214
to
221
| Ok(SubmitProofResponseMessage::InsufficientBalance(addr, last_sent_valid_nonce)) => { | ||
| // If we receive an invalid balance we should grab the last_sent_valid_nonce. | ||
| error!("Batcher responded with insufficient balance"); | ||
| Err(SubmitError::InsufficientBalance(addr)) | ||
| Err(SubmitError::InsufficientBalance( | ||
| addr, | ||
| last_sent_valid_nonce, | ||
| )) | ||
| } |
There was a problem hiding this comment.
i believe last_sent_valid_nonce was changed to errored_nonce (when removing the -1)
uri-99
reviewed
Dec 30, 2024
Comment on lines
198
to
203
| SubmitError::InsufficientBalance(addr, last_sent_valid_nonce) => { | ||
| write!( | ||
| f, | ||
| "Insufficient balance, address: {} last_sent_valid_nonce: {}", | ||
| addr, last_sent_valid_nonce | ||
| ) |
There was a problem hiding this comment.
i believe last_sent_valid_nonce was changed to errored_nonce (when removing the -1)
uri-99
reviewed
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially verified batch should display result of processing
Description
When submitting multiple proofs of the same
max_feethere is a possible case that the user's balance in theBatcherPaymentServicehas some but not all of the needed balance to pay cover submission. In this case aInsufficientBalanceerror will be thrown and some proofs will be processed while over error. Currently this is not displayed to the user and this pr seeks to shown this information by modifying the sdk and error message.Test Cases:
cd batcher/alignedSubmit proofs with the relevant test cases and observe the results deascribed in the images below.
All Proofs Fails w/ InsufficientBalance:
One Proof Fails w/ InsufficientBalance:
All Proofs are processed:
Some proofs fail with w/ InsufficientBalance:
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging