Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eigensdk-go version #650

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Conversation

entropidelic
Copy link
Contributor

@entropidelic entropidelic commented Jul 18, 2024

Bumps eigensdk-go from v0.1.6 to v0.1.9

The main changes were some APIs interfaces changes and structs names.

  1. For instantiating a new BLS aggregation service, an additional parameter has to be passed, hashFunction, and the BLS aggregation service method ProcessNewSignature now receives TaskResponse (which is just a go interface{}, so it can be anything) as an argument instead of TaskResponseDigest, which was done before. The v0.1.9 version can be seen here and the v0.1.6 here. What we were sending in v0.1.6as the TaskResponseDigest was really just the batch merkle root, so to fullfil the API requirements, a dummy hash function that outputs its input is being passed as the hashFunction argument. This should not affect in anything and will just replicate the behavior we were having in v0.1.6.
  2. The NewOperatorsInfoServiceInMemory function from the operatorsinfo module now receives a parameter logFilterQueryBlockRange, and if set to nil, a default value for that parameter is set. Check this lines and this comment.
  3. Some structs such as AvsRegistryReader and AvsRegistryWriterchanged their names to ChainReader and ChainWriter.

Testing

To test the PR, just test normal flow, ideally with more than one operator

@entropidelic entropidelic changed the title chore: bump eigensdk version chore: bump eigensdk-go version Jul 18, 2024
@entropidelic entropidelic marked this pull request as ready for review July 18, 2024 21:40
@entropidelic entropidelic self-assigned this Jul 18, 2024
Copy link
Contributor

@NicolasRampoldi NicolasRampoldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with 2 operators and worked as expected also code looks good

Copy link
Contributor

@uri-99 uri-99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked smoothly for me with 2 operators 👍

@entropidelic entropidelic merged commit 2219a1a into main Aug 1, 2024
8 checks passed
@entropidelic entropidelic deleted the chore-bump-eigensdk-version branch August 1, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants