-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump eigensdk-go
version
#650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entropidelic
changed the title
chore: bump eigensdk version
chore: bump Jul 18, 2024
eigensdk-go
version
…lize the BLS aggregator service
…o chore-bump-eigensdk-version
NicolasRampoldi
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it with 2 operators and worked as expected also code looks good
uri-99
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked smoothly for me with 2 operators 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps eigensdk-go from
v0.1.6
tov0.1.9
The main changes were some APIs interfaces changes and structs names.
hashFunction
, and the BLS aggregation service methodProcessNewSignature
now receivesTaskResponse
(which is just a gointerface{}
, so it can be anything) as an argument instead ofTaskResponseDigest
, which was done before. The v0.1.9 version can be seen here and the v0.1.6 here. What we were sending inv0.1.6
as theTaskResponseDigest
was really just the batch merkle root, so to fullfil the API requirements, a dummy hash function that outputs its input is being passed as thehashFunction
argument. This should not affect in anything and will just replicate the behavior we were having in v0.1.6.NewOperatorsInfoServiceInMemory
function from theoperatorsinfo
module now receives a parameterlogFilterQueryBlockRange
, and if set tonil
, a default value for that parameter is set. Check this lines and this comment.AvsRegistryReader
andAvsRegistryWriter
changed their names toChainReader
andChainWriter
.Testing
To test the PR, just test normal flow, ideally with more than one operator