🐛 Fix rgb

yhs0602 · Dec 31, 2024 · 485d9d0 · 485d9d0
1 parent 523aeb1
commit 485d9d0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/craftground/MinecraftEnv/src/main/cpp/framebuffer_capturer_apple.mm b/src/craftground/MinecraftEnv/src/main/cpp/framebuffer_capturer_apple.mm
@@ -108,7 +108,7 @@ int initializeIoSurface(
         GL_RGBA,
         width,
         height,
-        GL_RGBA,
+        GL_BGRA,
         GL_UNSIGNED_INT_8_8_8_8_REV,
         ioSurface,
         0

diff --git a/src/craftground/environment.py b/src/craftground/environment.py
@@ -450,12 +450,18 @@ def convert_observation(
                 ):
                     # already intialized
                     # drop alpha, flip y axis, and clone
-                    return self.observation_tensors[0].clone()[:, :, :3].flip(0), None
+                    return (
+                        self.observation_tensors[0].clone()[:, :, :[2, 1, 0]].flip(0),
+                        None,
+                    )
             else:
                 if self.observation_tensors[0] is not None:
                     # already intialized
                     # drop alpha, flip y axis, and clone
-                    return self.observation_tensors[0].clone()[:, :, :3].flip(0), None
+                    return (
+                        self.observation_tensors[0].clone()[:, :, :[2, 1, 0]].flip(0),
+                        None,
+                    )
 
             from .craftground_native import initialize_from_mach_port  # type: ignore
             from .craftground_native import mtl_tensor_from_cuda_mem_handle  # type: ignore
@@ -474,7 +480,9 @@ def convert_observation(
                 # print(image_tensor)
                 self.observation_tensors[0] = rgb_array_or_tensor
                 # drop alpha, flip y axis, and clone
-                rgb_array_or_tensor = rgb_array_or_tensor.clone()[:, :, :3].flip(0)
+                rgb_array_or_tensor = rgb_array_or_tensor.clone()[
+                    :, :, :[2, 1, 0]
+                ].flip(0)
             else:
                 # TODO: Handle cuda case also
                 cuda_dl_tensor = mtl_tensor_from_cuda_mem_handle(