Skip to content

Commit

Permalink
bug in choosing the far calculation method (gwastro#4593)
Browse files Browse the repository at this point in the history
* bug in which IFO combo is used for calculating the FAR in each combination during HR

* Safety catch
  • Loading branch information
GarethCabournDavies authored Dec 22, 2023
1 parent 8ab13ba commit feb8dfa
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions bin/all_sky_search/pycbc_add_statmap
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,8 @@ else:
f_in.attrs['background_time_exc'],
**significance_dict[ifo_combo_key])

del ifo_combo_key

logging.info('Combining false alarm rates from all available backgrounds')

# Convert dictionary of whether the ifo combination is available at trigger
Expand Down Expand Up @@ -611,7 +613,7 @@ while True:
sep_fg_data[key].data['stat'],
sep_bg_data[key].data['decimation_factor'],
bg_t_y,
**significance_dict[ifo_combo_key])
**significance_dict[key])
fg_far = significance.apply_far_limit(
fg_far,
significance_dict,
Expand All @@ -635,7 +637,7 @@ while True:
combined_fg_data.data['stat'],
sep_bg_data[key].data['decimation_factor'],
bg_time_ct[key],
**significance_dict[ifo_combo_key])
**significance_dict[key])
# Set up variable for whether each coincidence is available in each coincidence time
is_in_combo_time[key] = np.zeros(n_triggers)
end_times = np.array(f['segments/%s/end' % key][:])
Expand Down

0 comments on commit feb8dfa

Please sign in to comment.