Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/link suggest #253
Feat/link suggest #253
Changes from 3 commits
5678a6c
e3d055f
5fe112e
3bc7699
d616276
929b661
e1f2c2d
34bbbfa
dce09b7
42ccfcb
6554609
9f04c10
beb976a
1bf1829
a054f4d
fe0fb6a
ffb6c33
0cf4f32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to having a separate function handler for link suggestion different from scraped sites, maybe better to also have a separate tools module like
index_dapp_suggesstion
or somethingTrying to figure out how consistently the LLM is able to cite SOURCES in a reliable format, any insights on that?
We could also explore a more structured format for the results like a list of JSON objects with fields such as
dapp_name
,dapp_desc
,dapp_url
etc and then post-process it or send it to the FE as JSON to render it consistentlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is some overlap between both link suggestion and scraped sites modules as both seek to answer generic questions about the ecosystem.
If we use both of them, I suspect the model may not be able to reliably discern which one to use appropriately
Can you test this by having both enabled and see how the system performs? To test both of them, you will need to a have a separate widget command for each in the yaml
You can also remove your comments.