Feat/custom fork id #438
Feat/custom fork id #438
Conversation
✅ Deploy Preview for ironclad-parent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
getting the following error when trying to connect to the chain via metamask: 
|
|
|
||
| const DEFAULT_CHAIN_ID = 1; | ||
|
|
||
| const useChainId = () => { | ||
| const useChainId = (returnForkId?: boolean) => { |
There was a problem hiding this comment.
| const useChainId = (returnForkId?: boolean) => { | |
| const useChainId = (returnForkId = false) => { |
There was a problem hiding this comment.
what does returnForkId mean?
There was a problem hiding this comment.
UseChainId will return the ID of the forked network ( eg. 1 if we forked mainnet). However, that might not be the id returned by getNetwork().id .... there will likely be a need to have access to both. (For example, some deployed contracts might reference the id 1 , when the id returned by the network will be different ) .
| { network_id: 1, | ||
| block_number: currentBlockNumber, | ||
| chain_config: { | ||
| chain_id: 1277971 |
There was a problem hiding this comment.
can we or should we make the fork chain id an env variable?
There was a problem hiding this comment.
Could do so, I think better would be to simply append 127797.. to the current netwrok_id in this case.
This is because we need to point the FE to a tenderly that returns the correct fork number. :) ( |
|
@marcomariscal I think we should probably have a quick call to align up on this PR. |
No description provided.