Feat: combine multiple lines into one block, add a new option --block_size #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: some text is not replaced with translation
|
Relative issue #360 |
|
thanks will take a look later~ |
known issue: 1. sometime the original text show up 2. resume function not working
|
I want to mention the resume function doesn't work in this PR, but the rest are seems to be working properly. |
yihong0618
reviewed
Jan 18, 2024
book_maker/loader/epub_loader.py
Outdated
Comment on lines
130
to
161
| # def _process_paragraph(self, p, index, p_to_save_len): | ||
| # if not p.text or self._is_special_text(p.text): | ||
| # return index | ||
|
|
||
| # new_p = copy(p) | ||
|
|
||
| # for p_exclude in self.exclude_translate_tags.split(","): | ||
| # # for issue #280 | ||
| # if type(p) == NavigableString: | ||
| # continue | ||
| # for pt in new_p.find_all(p_exclude): | ||
| # pt.extract() | ||
|
|
||
| # if self.resume and index < p_to_save_len: | ||
| # new_p.string = self.p_to_save[index] | ||
| # else: | ||
| # if type(p) == NavigableString: | ||
| # new_p = self.translate_model.translate(new_p.text) | ||
| # self.p_to_save.append(new_p) | ||
| # else: | ||
| # new_p.string = self.translate_model.translate(new_p.text) | ||
| # self.p_to_save.append(new_p.text) | ||
|
|
||
| new_p = copy(p) | ||
| # self.helper.insert_trans( | ||
| # p, new_p.string, self.translation_style, self.single_translate | ||
| # ) | ||
| # index += 1 | ||
|
|
||
| # if index % 20 == 0: | ||
| # self._save_progress() | ||
|
|
||
| # return index |
There was a problem hiding this comment.
Sure, I can do that
|
@Ninzore thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issue: some text is not replaced with translation
I'm really not familiar with BS, please have a look