-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemini Enhancements #428
Merged
Merged
Gemini Enhancements #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks a lot will take a look these days |
Nice! very clean code, Thanks |
yihong0618
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances Gemini support with several improvements:
Gemini Translator Improvements:
gemini-1.5-flash
.use_context
,temperature
,prompt
, custom model lists (--model_list
), and key/model rotation, matching other translators.max_output_tokens
from 2048 to 8192.BLOCK_NONE
) to reduceBlockedPromptException
occurrences (though not entirely eliminated).Retry Strategy: The retry mechanism prioritizes key rotation on the first retry, switching to model rotation only on subsequent retries to minimize potential inconsistencies in translation quality.
New Option:
--interval [float]
(seconds) option to control request frequency. Exponential backoff is now implemented but the original fixed sleep time is retained. This addresses Gemini's lower RPM limits (1000-2000 vs. OpenAI's 10,000) and free tier restrictions. Suggested values: 0.03s for Gemini Flash (2000 RPM limit) and 4s for the free tier (15 RPM).Testing:
gemini_translator.py
(# print(model)
) to inspect the model object and verify parameter changes.python3 make_book.py --book_name test_books/animal_farm.epub --model gemini --test
python3 make_book.py --book_name test_books/animal_farm.epub --model geminipro --test
python3 make_book.py --book_name test_books/animal_farm.epub --model gemini --model_list gemini-1.5-pro-002,gemini-1.5-flash-002 --test --test_num 30 --use_context --temperature 0.5 --prompt prompt_template_sample.json --interval 0.1