-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 优化 github_svg 生成,从每年第一天开始 #765
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks will take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
but I think it will affect our users,
can we make it configurable? and set it default to True
thanks for your review how do you think that add an argument
If it makes sense, I will improve the code when I have time later. |
make sense and default is True is OK. |
LGTM. @me for approval when the argument is ok. |
acdcf0a
to
1fc61c0
Compare
1fc61c0
to
7c74048
Compare
7c74048
to
e1db83c
Compare
e1db83c
to
90927eb
Compare
90927eb
to
7140eb8
Compare
please review this code again @yihong0618 @NaturezzZ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much
github 的 年度图已经是从第一天开始绘画,会跳过第一周但是非本年的日子, 如下图

本次修改从 向上一年补齐格子的逻辑改成了跳过格子,从每年的第一天开始绘画

修改前:
修改后:
