Use env variables instead of constants

[rustamwin]

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	✔️/❌
Fixed issues	#190

[BoShurik]

What about moving Environment class to a file bootstrap.php?
Something like this:

require_once __DIR__ . '/vendor/autoload.php'

$dotenv = Dotenv::createImmutable(dirname(__DIR__, 2));
$dotenv->load();

$_ENV['YII_ENV'] = empty($_ENV['YII_ENV'])
    ? self::DEFAULT_YII_ENV
    : (string)$_ENV['YII_ENV'];
$_SERVER['YII_ENV'] = $_ENV['YII_ENV'];

$_ENV['YII_DEBUG'] = empty($_ENV['YII_DEBUG'])
    ? self::DEFAULT_YII_DEBUG
    : filter_var(
        $_ENV['YII_DEBUG'],
        FILTER_VALIDATE_BOOLEAN,
        FILTER_NULL_ON_FAILURE
    ) ?? self::DEFAULT_YII_DEBUG;
$_SERVER['YII_DEBUG'] = $_ENV['YII_DEBUG'];

if ($_ENV['YII_ENV'] === 'test') {
    $c3 = dirname(__DIR__) . '/c3.php';

    if (is_file($c3)) {
        require_once $c3;
    }
}

In that case we can get rid of an index-test.php file and Environment class that do not related to the application business logic. Also this is a good place for future preloading

[samdark]

Getting rid of index-test.php is a good idea.

[samdark]

@rustamwin would you please resolve conflicts and try @BoShurik idea?

[rustamwin]

@rustamwin would you please resolve conflicts and try @BoShurik idea?

Yes.

[vjik]

Config is created in entry points:

$config = new Config(
	dirname(__DIR__, 2),
	'/config/packages', // Configs path.
	$this->environment,
	[
		'params',
		'events',
		'events-web',
		'events-console',
	],
);

Root path, configs paths and recursive merge groups should be same in all entry points. Maybe create ConfigFactory?

[yiiliveext]

What about moving Environment class to a file bootstrap.php?
Something like this:

require_once __DIR__ . '/vendor/autoload.php'

$dotenv = Dotenv::createImmutable(dirname(__DIR__, 2));
$dotenv->load();

$_ENV['YII_ENV'] = empty($_ENV['YII_ENV'])
    ? self::DEFAULT_YII_ENV
    : (string)$_ENV['YII_ENV'];
$_SERVER['YII_ENV'] = $_ENV['YII_ENV'];

$_ENV['YII_DEBUG'] = empty($_ENV['YII_DEBUG'])
    ? self::DEFAULT_YII_DEBUG
    : filter_var(
        $_ENV['YII_DEBUG'],
        FILTER_VALIDATE_BOOLEAN,
        FILTER_NULL_ON_FAILURE
    ) ?? self::DEFAULT_YII_DEBUG;
$_SERVER['YII_DEBUG'] = $_ENV['YII_DEBUG'];

if ($_ENV['YII_ENV'] === 'test') {
    $c3 = dirname(__DIR__) . '/c3.php';

    if (is_file($c3)) {
        require_once $c3;
    }
}

In that case we can get rid of an index-test.php file and Environment class that do not related to the application business logic. Also this is a good place for future preloading

The name of the file is the same as config/bootstrap.php. This can be misleading.

[samdark]

How about proving a default value here?

Suggested change

	YII_ENV=
	YII_ENV=dev

[rustamwin]

The default value is '/'. See config plugin.

[samdark]

That's usually not only config environment.

[samdark]

That's usually not only config environment.

[samdark]

👍 Would you please apply that to app-api, demo and demo-api as well?

[rustamwin]

+1 Would you please apply that to app-api, demo and demo-api as well?

Yes.