Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CsrfHeaderMiddleware #68

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

olegbaturin
Copy link

@olegbaturin olegbaturin commented Sep 27, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

#65

Added new CsrfHeaderMiddleware
Added new method CsrfMiddleware::withSafeMethods()

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5d18903) to head (1792f4d).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #68   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        47        57   +10     
===========================================
  Files              8         9    +1     
  Lines            128       159   +31     
===========================================
+ Hits             128       159   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark marked this pull request as draft September 27, 2024 17:39
@olegbaturin olegbaturin marked this pull request as ready for review October 21, 2024 06:53
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/CsrfHeaderMiddleware.php Outdated Show resolved Hide resolved
@samdark samdark requested a review from a team October 26, 2024 21:54
src/CsrfMiddleware.php Outdated Show resolved Hide resolved
src/CsrfHeaderMiddleware.php Show resolved Hide resolved
src/CsrfHeaderMiddleware.php Show resolved Hide resolved
src/CsrfHeaderMiddleware.php Outdated Show resolved Hide resolved
@olegbaturin olegbaturin requested a review from vjik October 28, 2024 07:55
Comment on lines +121 to +122

`config/web/di/csrf.php`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`config/web/di/csrf.php`

Comment on lines +258 to +259

`config/web/di/csrf.php`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`config/web/di/csrf.php`

@vjik vjik requested a review from samdark November 2, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants