Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #70: Deprecate CsrfMiddlware class and add CsrfTokenMiddleware instead #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ev-gor
Copy link

@ev-gor ev-gor commented Oct 31, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Fix #70

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (5d18903) to head (7d98cac).
Report is 12 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff               @@
##              master      #71       +/-   ##
==============================================
- Coverage     100.00%   77.10%   -22.90%     
- Complexity        47       61       +14     
==============================================
  Files              8        9        +1     
  Lines            128      166       +38     
==============================================
  Hits             128      128               
- Misses             0       38       +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ev-gor
Copy link
Author

ev-gor commented Oct 31, 2024

I just copy/paste existing code, but I can add missing tests if needed

@vjik vjik requested a review from a team October 31, 2024 19:18
@vjik vjik added the status:code review The pull request needs review. label Oct 31, 2024
@samdark
Copy link
Member

samdark commented Nov 1, 2024

@ev-gor deprecated class could be excluded from testing.

@vjik
Copy link
Member

vjik commented Nov 2, 2024

@ev-gor deprecated class could be excluded from testing.

Why? It's reduced code coverage. I suggest removing tests for deprecate classes at the time of their deletion.

@samdark
Copy link
Member

samdark commented Nov 3, 2024

Alright. @vjik suggestion makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename CsrfMiddlware to CsrfTokenMiddleware
3 participants