Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimal PHP version to 8.1 #42

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Raise minimal PHP version to 8.1 #42

merged 2 commits into from
Feb 14, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 13, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 13, 2024

PR Summary

  • Updated Workflow Files

    • Various workflow files (build.yml, composer-require-checker.yml, mutation.yml, static.yml) were updated to include changes in parameters like pushing new changes to the master branch and upgrading PHP versions to more recent iterations ('8.1', '8.2', '8.3').
  • PHP Version Updated

    • The PHP version was uniformly updated across different files (README.md, composer.json, .scrutinizer.yml) to 8.1, indicating that the necessary environment for running this project now requires PHP version 8.1 or higher.
  • Updated Composer dependencies

    • The composer.json file noticed changes in the versions of some dependencies (like phpunit/phpunit, rector/rector, and vimeo/psalm), suggesting improvements and bug fixes that come with these new versions.
  • Added issue handler and new rule in rector.php

    • A new issue handler, RiskyTruthyFalsyComparison, was added to psalm.xml to improve code analysis and verification. Meanwhile, rector.php was updated with a new PHP level and a new rule was added to skip certain rectors.
  • Improved Data Reader

    • A significant change in AbstractQueryDataReader.php was made where a new property $count was added for containing the number of elements. Now, rather than returning the result instantly, the count method assigns it to this property.
  • Cleaned Up Filter Files

    • For readability and cleanliness, several redundant inline docblocks have been removed from the Filter/CompareFilter.php file. It’s now easier to understand method signatures and the formatValues method implementation.
    • On another note, Filter/Exists.php was modified to make the query property read-only, enhancing the safety and robustness of the code.

@vjik vjik requested a review from a team February 13, 2024 18:52
@vjik vjik added the status:code review The pull request needs review. label Feb 13, 2024
@vjik vjik merged commit 7a44842 into master Feb 14, 2024
17 checks passed
@vjik vjik deleted the php81 branch February 14, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants