Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore DB filters #45

Closed
wants to merge 1 commit into from
Closed

Conversation

Gerych1984
Copy link
Contributor

@Gerych1984 Gerych1984 commented Feb 21, 2024

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
Fixed issues #38

Restore separate Db Filters

Copy link

what-the-diff bot commented Feb 21, 2024

PR Summary

  • Additions to AbstractQueryDataReader.php File
    The AbstractQueryDataReader.php file has been updated to handle the new batchSize property, clone the query object before applying filters, use the criteriaHandler to apply filters and conditions, and improve offset and limit management.

  • Changes to CriteriaHandler.php File
    The CriteriaHandler.php file has been updated to allow adding a single handler, handle operators more effectively, and accept variadic parameters for QueryHandlerInterface.

  • Added New Filter Classes
    Several new classes like Between.php, CompareFilter.php, Equals.php, GreaterThan.php, ILike.php, etc., were added in the Filter folder to handle various comparison operators.

  • Added ParamsTrait.php and QueryFilterInterface.php
    Two new files were added under src/Filter for managing parameters and implementing the extended FilterInterface.

  • Changes to src/FilterHandler Directory
    Various files under src/FilterHandler directory were modified to import new classes, extend the AbstractHandler class, and update the operator handling. CompareHandler.php and Context.php files were deleted. New handler classes have been added for "ilike", "like", "or ilike", and "or like" operators.

  • Modifications to QueryHandlerInterface File
    The QueryHandlerInterface was updated to include new methods for applying filter and condition and handling the "not" operator.

  • Removal of Certain Files
    The ValueNormalizer, ValueNormalizerInterface, DbDataFilterTest, and DataFilterTest files were removed from the repository.

Overall, this PR focuses on enhancing query data reading, improving filtering controls, and efficiently handling various operators, thus providing a more functional and robust data handling process.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (e4db023) to head (86bae77).
Report is 1 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #45       +/-   ##
=============================================
+ Coverage     74.03%   95.04%   +21.00%     
- Complexity      130      192       +62     
=============================================
  Files            22       42       +20     
  Lines           312      464      +152     
=============================================
+ Hits            231      441      +210     
+ Misses           81       23       -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gerych1984 Gerych1984 force-pushed the restore-filters branch 9 times, most recently from 77207b1 to 073ec28 Compare February 23, 2024 12:18
@Gerych1984 Gerych1984 marked this pull request as ready for review February 23, 2024 12:24
@Gerych1984 Gerych1984 force-pushed the restore-filters branch 2 times, most recently from 9e333e9 to 5053f7d Compare February 23, 2024 18:09
@samdark samdark requested a review from vjik February 23, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant