Change property Schema::$typeMap to constant Schema::TYPE_MAP (#286)

yiisoft · Nov 16, 2023 · 5276702 · 5276702
1 parent cb2d47a
commit 5276702
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 1.1.1 under development
 
-- no changes in this release.
+- Enh #286: Change property `Schema::$typeMap` to constant `Schema::TYPE_MAP` (@Tigrov)
 
 ## 1.1.0 November 12, 2023
 

diff --git a/src/Schema.php b/src/Schema.php
@@ -63,11 +63,11 @@ final class Schema extends AbstractPdoSchema
     protected string|null $defaultSchema = 'dbo';
 
     /**
-     * @var array Mapping from physical column types (keys) to abstract column types (values).
+     * Mapping from physical column types (keys) to abstract column types (values).
      *
-     * @psalm-var string[]
+     * @var string[]
      */
-    private array $typeMap = [
+    private const TYPE_MAP = [
         /** Exact numbers */
         'bigint' => self::TYPE_BIGINT,
         'numeric' => self::TYPE_DECIMAL,
@@ -440,8 +440,8 @@ protected function loadColumnSchema(array $info): ColumnSchemaInterface
         if (preg_match('/^(\w+)(?:\(([^)]+)\))?/', $dbType, $matches)) {
             $type = $matches[1];
 
-            if (isset($this->typeMap[$type])) {
-                $column->type($this->typeMap[$type]);
+            if (isset(self::TYPE_MAP[$type])) {
+                $column->type(self::TYPE_MAP[$type]);
             }
 
             if ($type === 'bit') {