Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColumnSchemaTest #272

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jul 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Jul 20, 2023

PR Summary

  • Addition of ColumnSchemaTest.php
    This update introduces a new test, specifically for checking how our system handles various types of data. The test will ensure that all information is processed and stored correctly.

  • Minor modifications in QueryBuilderProvider.php and SchemaProvider.php
    The label 'time', used to identify a particular type of data column, has been renamed to 'datetime_col'. This change is being made to increase clarity and avoid any potential confusion in the future.

  • Update in mssql.sql Fixture File
    In line with the changes made in the PHP files, the definition for the 'type' table in the fixture file has also been updated - the 'time' column is now known as 'datetime_col'.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2d633f5) 97.76% compared to head (27185eb) 97.76%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #272   +/-   ##
=========================================
  Coverage     97.76%   97.76%           
  Complexity      221      221           
=========================================
  Files            15       15           
  Lines           627      627           
=========================================
  Hits            613      613           
  Misses           14       14           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tigrov Tigrov marked this pull request as ready for review July 20, 2023 13:18
@samdark samdark requested a review from darkdef July 21, 2023 08:13
@samdark samdark merged commit 321ab70 into yiisoft:master Jul 24, 2023
16 of 17 checks passed
@Tigrov Tigrov deleted the add_column_schema_test branch August 5, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants