Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DateTime instances #273

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 5, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues #725

@what-the-diff
Copy link

what-the-diff bot commented Aug 5, 2023

PR Summary

  • Improved Date and Time Columns Handling
    This set of changes is about better handling of date and time columns and introduces a number of improvements. A new method hasTimezone() was added that helps in dealing with date-time values in different time zones.

  • Added Timestamp Data Type
    The timestamp data type, crucial for tracking changes precisely down to the millisecond, has been added. This aids in achieving detailed and accurate change tracking within the system.

  • Enhanced Testing Framework
    Numerous tests have been added or altered to verify the system's improved handling for various date time columns. This should assure that these upgrades perform as expected and won't break any existing functionalities.

  • Additional Columns and Column Modifications
    Several new columns dealing with different date and time formats were added or modified across different files. For instance, columns now handling datetime2 values, datetimeoffset values, date only values, and time only values.

  • Updated Default Value Handling
    There's been an update on several default values for specific columns. For instance, the default value for datetime_col is now 2023-06-11 15:24:11.123. This ensures that data is maintained even when no input is provided during a transaction, improving the robustness of the system.

  • Altered Test Expectations
    Few tests expectations were modified to match the new default value formats for date/time columns which will help to verify that the new date and time format handling is working as expected.

  • Modified Column PHP Types
    The PHP type of certain columns is updated. For instance, the Myrowversion column's PHP type was changed from 'string' to 'resource'. This ensures more accurate representation and handling of respective data types within the system.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (9747d60) 97.76% compared to head (41f2749) 97.80%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
+ Coverage     97.76%   97.80%   +0.04%     
- Complexity      221      225       +4     
============================================
  Files            15       15              
  Lines           627      639      +12     
============================================
+ Hits            613      625      +12     
  Misses           14       14              
Files Changed Coverage Δ
src/ColumnSchema.php 100.00% <100.00%> (ø)
src/Schema.php 95.30% <100.00%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 5, 2023 16:18
@Tigrov Tigrov marked this pull request as draft August 17, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant