Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace call of SchemaInterface::getRawTableName() to QuoterInterface::getRawTableName() #308

Merged
merged 1 commit into from
May 10, 2024
Merged

Replace call of SchemaInterface::getRawTableName() to QuoterInterface::getRawTableName() #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Enh #293: Implement `SqlParser` and `ExpressionBuilder` driver classes (@Tigrov)
- Chg #306: Remove parameter `$withColumn` from `Quoter::getTableNameParts()` method (@Tigrov)
- Chg #308: Replace call of `SchemaInterface::getRawTableName()` to `QuoterInterface::getRawTableName()` (@Tigrov)

## 1.2.0 March 21, 2024

Expand Down
2 changes: 1 addition & 1 deletion src/Schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
*
* @var string[]
*/
private const TYPE_MAP = [

Check failure on line 71 in src/Schema.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

MissingClassConstType 

src/Schema.php:71:19: MissingClassConstType: Class constant "Yiisoft\Db\Mssql\Schema::TYPE_MAP" should have a declared type. (see https://psalm.dev/359)

Check failure on line 71 in src/Schema.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

MissingClassConstType 

src/Schema.php:71:19: MissingClassConstType: Class constant "Yiisoft\Db\Mssql\Schema::TYPE_MAP" should have a declared type. (see https://psalm.dev/359)
/** Exact numbers */
'bigint' => self::TYPE_BIGINT,
'numeric' => self::TYPE_DECIMAL,
Expand Down Expand Up @@ -907,7 +907,7 @@
*/
protected function getCacheKey(string $name): array
{
return array_merge([self::class], $this->generateCacheKey(), [$this->getRawTableName($name)]);
return array_merge([self::class], $this->generateCacheKey(), [$this->db->getQuoter()->getRawTableName($name)]);
}

/**
Expand Down
Loading