Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnSchema classes for performance of typecasting #236

Merged
merged 12 commits into from
May 30, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 1, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues yiisoft/db#737

@what-the-diff
Copy link

what-the-diff bot commented Sep 1, 2023

PR Summary

  • Introduced a new file BinaryColumnSchema.php.
    A new class BinaryColumnSchema has been added to handle complex binary column operations.
  • Deprecation warning in ColumnSchema.php.
    The direct usage of ColumnSchema class is now discouraged in favor of specific type classes. This class now contains fixes to suppress warnings related to this change.
  • Changes to Schema.php file.
    This file now has a renamed method, supports a broader range of parameters, and contains new methods for creating column schemas based on different PHP types. The updates encourage better usage of specific type classes and provide more efficient way of working with databases.
  • Improvements to ColumnSchemaTest.php.
    New test methods have been added to check instances of column schema and to verify the functionality of the new BinaryColumnSchema class. This ensures the reliability of the new changes introduced.
  • Addition of ColumnSchemaProvider.php.
    This file extends the functionality of its parent class to now use the BinaryColumnSchema class specifically for binary type columns, which improves the handling of these complex data types in our application.

@Tigrov Tigrov marked this pull request as ready for review September 1, 2023 15:38
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (e1275ac) to head (9dc9f00).
Report is 11 commits behind head on master.

Current head 9dc9f00 differs from pull request most recent head 64f3211

Please upload reports for the commit 64f3211 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #236      +/-   ##
============================================
- Coverage     98.02%   96.99%   -1.03%     
- Complexity      175      195      +20     
============================================
  Files            16       17       +1     
  Lines           556      599      +43     
============================================
+ Hits            545      581      +36     
- Misses           11       18       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:under development Someone is working on a pull request. label Jan 31, 2024
@Tigrov Tigrov added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels May 5, 2024
@Tigrov Tigrov merged commit a8529da into yiisoft:master May 30, 2024
16 of 17 checks passed
@Tigrov Tigrov deleted the column_type_classes2 branch May 30, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants