Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Query without ->from() #238

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 27, 2023

Related PR

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #239

@what-the-diff
Copy link

what-the-diff bot commented Sep 27, 2023

PR Summary

  • Introduction of a New Method in DQLQueryBuilder Class
    A new function named buildFrom has been incorporated into the DQLQueryBuilder class. The benefit of this change is that it lets the system return a default 'FROM DUAL' value when no parameter is specified. If parameters are indeed provided, it takes them and uses the parent class's buildFrom function.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (805e639) 98.18% compared to head (cf97295) 98.20%.

❗ Current head cf97295 differs from pull request most recent head c9df69d. Consider uploading reports for the commit c9df69d to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #238      +/-   ##
============================================
+ Coverage     98.18%   98.20%   +0.01%     
- Complexity      173      175       +2     
============================================
  Files            16       16              
  Lines           552      556       +4     
============================================
+ Hits            542      546       +4     
  Misses           10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review January 10, 2024 13:14
@Tigrov Tigrov merged commit 8e05361 into yiisoft:master Jan 14, 2024
1 of 2 checks passed
@Tigrov Tigrov deleted the select-without-from branch January 14, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants