Skip to content

Rename getLastInsertID() method in ConnectionInterface to getLastInsertId() #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 30, 2025

Q A
Is bugfix?
New feature?
Breaks BC?

Related to yiisoft/db#965

@vjik vjik requested a review from a team April 30, 2025 10:39
@vjik vjik added the status:code review The pull request needs review. label Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (efa778f) to head (8bb9cf1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage     97.78%   97.78%           
  Complexity      227      227           
=========================================
  Files            22       22           
  Lines           769      769           
=========================================
  Hits            752      752           
  Misses           17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik merged commit faea3d9 into master May 1, 2025
19 checks passed
@vjik vjik deleted the rename-get-last-insert-id branch May 1, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants