Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realize column factory #355

Merged
merged 6 commits into from
Sep 1, 2024
Merged

Realize column factory #355

merged 6 commits into from
Sep 1, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 13, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues yiisoft/db#854

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.51%. Comparing base (03a6340) to head (e68661a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Column/ColumnFactory.php 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #355      +/-   ##
============================================
+ Coverage     98.80%   99.51%   +0.70%     
+ Complexity      288      286       -2     
============================================
  Files            25       26       +1     
  Lines           839      822      -17     
============================================
- Hits            829      818      -11     
+ Misses           10        4       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 2402d7d into master Sep 1, 2024
21 of 22 checks passed
@Tigrov Tigrov deleted the add-column-factory branch September 1, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants