Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColumnSchemaTest #261

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jul 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Jul 20, 2023

PR Summary

  • Introduction of new test in ColumnSchemaTest.php
    This PR introduces a new test called testPhpTypeCast which checks how the system manages data type conversions when pulling out information from a SQLite database table. This ensures that the system accurately understands and handles the data it retrieves.

  • Column name change in SchemaProvider.php
    The column, previously named time, has been renamed to timestamp_col in SchemaProvider.php. This provides more accuracy and clarity about the kind of data this column holds.

  • Modification in sqlite.sql
    Corresponding to the change in SchemaProvider.php, the time column in the type table within sqlite.sql has been renamed to timestamp_col. The default value for this column has also been adjusted, responding to the change in column definition.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (032e1b3) 98.20% compared to head (09cda28) 98.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #261   +/-   ##
=========================================
  Coverage     98.20%   98.20%           
  Complexity      323      323           
=========================================
  Files            17       17           
  Lines          1005     1005           
=========================================
  Hits            987      987           
  Misses           18       18           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tigrov Tigrov marked this pull request as ready for review July 20, 2023 12:23
@terabytesoftw terabytesoftw requested a review from a team July 20, 2023 16:03
@samdark samdark requested a review from darkdef July 21, 2023 08:13
@samdark samdark merged commit af9a6ce into yiisoft:master Jul 24, 2023
16 of 17 checks passed
@samdark
Copy link
Member

samdark commented Jul 24, 2023

👍

@Tigrov Tigrov deleted the add_column_schema_test branch July 30, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants