Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm error #265

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Fix psalm error #265

merged 5 commits into from
Aug 2, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Aug 1, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Aug 1, 2023

PR Summary

  • Modification of internalExecute in Command.php
    This update changes the way our system processes instructions within a specific type of operation, known as a "transaction". Previously, we were using a defined and strict method; now we've switched to an anonymous function, which is a more flexible approach that doesn't require pre-defined parameters. This can enhance our system's adaptability in handling transactions.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (074202f) 98.20% compared to head (5b40e86) 98.21%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #265   +/-   ##
=========================================
  Coverage     98.20%   98.21%           
  Complexity      325      325           
=========================================
  Files            17       17           
  Lines          1004     1006    +2     
=========================================
+ Hits            986      988    +2     
  Misses           18       18           
Files Changed Coverage Δ
src/Command.php 98.91% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team August 1, 2023 09:35
@vjik vjik added the status:code review The pull request needs review. label Aug 1, 2023
@vjik vjik merged commit b172ec9 into master Aug 2, 2023
20 checks passed
@vjik vjik deleted the fix-psalm branch August 2, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants