Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DMLQueryBuilder #271

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 19, 2023

Related with yiisoft/db#746

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues

@what-the-diff
Copy link

what-the-diff bot commented Aug 19, 2023

PR Summary

  • Streamlining of DMLQueryBuilder.php

    • Unused components that were previously burdening the file have been eliminated. This includes the removal of unused imports for specific functions. The flow of operations within the resetSequence method has been enhanced through an optimization of how the $key variable is generated. Additionally, the upsert method has been streamlined, making it simpler and more straightforward by eliminating unnecessary elements.
  • Enhancements to QueryBuilderProvider.php

    • A new test scenario has been incorporated. It will examine cases where routine data insertion is undertaken, and the unique column is not the first one. This will increase our checks and balances for the upsert method, thereby ensuring optimal functioning.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bf147f) 98.47% compared to head (13c43c1) 98.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #271      +/-   ##
============================================
- Coverage     98.47%   98.46%   -0.02%     
+ Complexity      343      342       -1     
============================================
  Files            19       19              
  Lines          1046     1039       -7     
============================================
- Hits           1030     1023       -7     
  Misses           16       16              
Files Coverage Δ
src/DMLQueryBuilder.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 19, 2023 11:26
src/DMLQueryBuilder.php Show resolved Hide resolved
@Tigrov Tigrov merged commit 11f981b into yiisoft:master Nov 1, 2023
17 of 19 checks passed
@Tigrov Tigrov deleted the refactor_dml_query_builder branch November 1, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants