Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code in Command class + Cleanup psalm annotations #281

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 13, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 13, 2023

PR Summary

This update entails significant code cleanup across different classes, mainly focusing on removing unused parts of the code, which includes unnecessary comments and docblocks. The key goal of this is to improve the readability and maintainability of the codebase.

  • Code Cleanup in Command class
    The Command class has been updated by removing unused code. This makes the class more efficient and streamlined.

  • Removal of Unused Comments
    Certain commented lines of code have been removed from AbstractTokenizer.php and JsonExpressionBuilder.php. This simplifies the files and makes them easier to understand.

  • Update and Cleanup in Query Building Classes
    Commented docblock parameters and unused variable comments were removed in multiple classes like DMLQueryBuilder.php, DQLQueryBuilder.php and QueryBuilder.php. Also, variable docblocks were updated where necessary, enhancing overall readability and understanding.

  • Major Cleanup in Schema class
    The Schema.php class has undergone an extensive cleanup by removing numerous commented-out docblock parameters and updating variable docblocks. This will help clear up any confusion and make the class easier to navigate for future revisions.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de04d85) 98.42% compared to head (81fd440) 98.42%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
- Coverage     98.42%   98.42%   -0.01%     
+ Complexity      332      330       -2     
============================================
  Files            19       19              
  Lines          1018     1016       -2     
============================================
- Hits           1002     1000       -2     
  Misses           16       16              
Files Coverage Δ
src/AbstractTokenizer.php 95.77% <ø> (ø)
src/Builder/JsonExpressionBuilder.php 100.00% <ø> (ø)
src/Command.php 98.55% <ø> (-0.05%) ⬇️
src/DMLQueryBuilder.php 100.00% <ø> (ø)
src/DQLQueryBuilder.php 100.00% <ø> (ø)
src/QueryBuilder.php 100.00% <ø> (ø)
src/Schema.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team November 13, 2023 13:21
@vjik vjik added the status:code review The pull request needs review. label Nov 13, 2023
@vjik vjik merged commit e3d9164 into master Nov 15, 2023
21 checks passed
@vjik vjik deleted the cleanup branch November 15, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants